Use plugin patcher to inject remote plugin runtime. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
amisevsk
reviewed
Aug 26, 2019
| pluginContainerCommand: ["sh", "-c"] | ||
| pluginContainerArgs: ["/plugins/remote-launcher/entrypoint.sh"] | ||
| initContainers: | ||
| - name: theia-remote-plugin-laucher |
There was a problem hiding this comment.
Suggested change
| - name: theia-remote-plugin-laucher | |
| - name: theia-remote-plugin-launcher |
| pluginContainerArgs: ["/plugins/remote-launcher/entrypoint.sh"] | ||
| initContainers: | ||
| - name: theia-remote-plugin-laucher | ||
| image: aandrienko/che-theia-endpoint-runtime:next |
There was a problem hiding this comment.
We should avoid using personal registries here if possible
davidfestal
requested changes
Aug 26, 2019
| @@ -46,6 +46,19 @@ spec: | |||
| attributes: | |||
| protocol: http | |||
| discoverable: false | |||
| pluginPatcher: | |||
There was a problem hiding this comment.
So we changed the meta.yaml model without increasing the apiVersion ?
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
|
Close on favour: #233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use plugin patcher to inject remote plugin runtime.
Referenced issue:
eclipse-che/che#13387
Depends on:
eclipse-che/che-plugin-broker#71
eclipse-che/che-theia#410
eclipse-che/che#14333
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com